text: Wrap* should account for display width; fixes #344 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12322158644Details
💛 - Coveralls |
|
jedib0t
commented
Dec 13, 2024
| @@ -111,7 +110,7 @@ func appendChar(char rune, wrapLen int, lineLen *int, inEscSeq bool, lastSeenEsc | |||
|
|
|||
| // increment the line index if not in the middle of an escape sequence | |||
| if !inEscSeq { | |||
| *lineLen++ | |||
| *lineLen += RuneWidth(char) | |||
There was a problem hiding this comment.
@L0nm4r this line was the buggy line resulting in misaligned text during wrapping.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
textpackage Wrap* functions were not accounting for display width when wrapping a word or a sentence. This changes fixes it.Addl. change: rename
RuneWidthWithoutEscSequencestoStringWidthWithoutEscSequencesin a backward compatible way.