add module-ignore flag #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
commented
Feb 20, 2022
| expect(result).to.have.length(8).and.deep.equal([1165, 1890, 985, 1213, 1654, 2000, 2001, 2100]); | ||
| expect(result).to.have.length(7).and.deep.equal([1165, 1890, 985, 1213, 2000, 2001, 2100]); |
There was a problem hiding this comment.
mock data had some data points that had gone past the set expiration date, requiring the test fixes in this file
added 2 commits
February 20, 2022 17:11
ghost
marked this pull request as ready for review
|
+1 on this update. Would help us tremendously. Thanks @alexburkowskypolysign |
|
this is a great feature, thank you for contributing @alexburkowskypolysign ! |
|
You are very welcome @jeemok! Thanks for merging |
|
will it support if we include in .nsprc file as well ? |
|
@Sujay-shetty not currently, but definitely sounds like a good feature. Can you help to create a new issue and we can track it from there? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To address feature request: #69
This fixes the issue where vulnerabilities disputed by package owners causes ever changing vulnerability ids in the audit report. In my repo I have to a seemingly infinite number of ids to my
.nsprcto manage the currently disputedlodashissue:Having a single flag to ignore
lodashrather than w/e next id pops up for the same vulnerability is a huge time saver in a team environment :).TODO
Screenshots
Tested via
npm linkNo flags, remove nsprc code for lodash (1 module):
-mflag 1 module:--module-ignoreflag 1 module:--module-ignoreflag 2 modules (removedlodashandhermes-engineids fromnsprc):@jeemok @GrzesiekP @IPWright83