Locale combobox in the Add-On Settings blank by default, causes "undefined" header labels

[turekv]

I have run into the resolved issue #168 in Linux with a Czech (cs_CZ, i.e., unsupported) locale and RWH v.3.2.0. The problem stemmed from the fact that the locale combobox was blank by default, and I had to select a suitable locale for the "undefined" header labels to become "From" etc.

If no locale match is found among the supported locales, it might be a good idea to use, e.g., US English by default.

Additional information:

• OS: Linux x64
• TB: 128.1.0esr (64-bit)
• RWH: 3.2.0
• OS/TB locale: cz_CZ

[jeevatkm]

@turekv, you're correct. The correct approach is to default to English. Is it still occurring? I fixed it as part of the v3.2.0 release.
https://github.com/jeevatkm/ReplyWithHeaderMozilla/blob/cffbed9d46b5da3b7efc5581d4d42588deb0d6bc/background.js#L44

I will investigate it; thanks for bringing it up.

[turekv]

Unfortunately yes, because my test setup included RWH v.3.2.0.

[jeevatkm]

@turekv I have fixed this bug for good. Can you please test it?

replywithheader-v3.3.0-dev.xpi.zip

PS: Extract zip file and then install it.

[turekv]

No problem. With a fresh TB profile (tested on cs_CZ Win & Linux), the locale still was not set after I installed the add-on (see the attached image). I.e., I encountered those "undefined" header labels again.

I also had to change at least one thing in the settings (e.g., "12hr format" --> "24hr format"; so that the add-on preferences were stored) in order for the add-on to start doing what it was supposed to do. Until something got modified here, the default Thunderbird attribution ("On DATE, SENDER wrote:") was used.

Incidentally, I noticed a typo in the top-left combobox ("Select AN Identities" -- highlighted in the attached screenshot as well).

[jeevatkm]

@turekv Thanks for your feedback. Can you please try this?

replywithheader-v3.3.0-dev.xpi.zip

[turekv]

With new TB profiles, the default add-on locale was "English (en-US)" when tested on Win/Linux with an unsupported OS/TB locale selected. I.e., this issue has been resolved. (thumbs up)

The other two problems I mentioned last time (the add-on not working at all without at least some of its settings being modified + "Select AN Identities") remain, but that is understandable. Most likely, you will wish to create separate bug reports for them.

[jeevatkm]

@turekv Thanks for validating it; it's good to hear that the locale issue is resolved.

I also had to change at least one thing in the settings (e.g., "12hr format" --> "24hr format"; so that the add-on preferences were stored) in order for the add-on to start doing what it was supposed to do. Until something got modified here, the default Thunderbird attribution ("On DATE, SENDER wrote:") was used.

I tried to replicate it on my Mac, but I couldn't.
For your information, all settings are created with a default value during the new add-on installation. In the update scenario, TB preserves all add-on settings, and during the add-on's uninstall, TB removes all the settings.

Incidentally, I noticed a typo in the top-left combobox ("Select AN Identities" -- highlighted in the attached screenshot as well).

Typically, TB could have "N" of mail identity in the Mail Accounts. By default, all Identities are enabled; if users want to disable RWH on a particular identity, they can uncheck it from the "Select an Identities" dropdown.

If I misunderstood anything, please let me know.

[turekv]

I tried to replicate it on my Mac, but I couldn't. For your information, all settings are created with a default value during the new add-on installation. In the update scenario, TB preserves all add-on settings, and during the add-on's uninstall, TB removes all the settings.

Hmm, strange. However, something fishy is going on there, because in the course of both recent tests RWH really did not work "out of the box". This is what I saw after installing the add-on before I faffed about in the settings:

If I misunderstood anything, please let me know.

What I meant was that it reads "[...] AN IdentitieS" (notice the indefinite article and the plural). It should either be "Select Identities" (if there are more than one), or "Select an Identity" (if there is just one and you really wish to respect the number of available identities in the combobox description).

[jeevatkm]

@turekv Thanks for the details.

• I will continue investigating the root cause of the first install not working OOTB. After looking at the screenshot, I'm wondering where it could be failing; quick thoughts are - (I will create a new issue)
  • First, install not working with already supported Locale
  • First, install not working with un-supported Locale
• Now I understand I will correct it as "Select Identities" (I will update it as part of current issue)

[turekv]

No problem, thanks.

[jeevatkm]

@turekv I'm wondering, is it possible to write 5-star review here? https://addons.thunderbird.net/en-US/thunderbird/addon/replywithheader/

[turekv]

You already have my 5-star rating there. :)

[jeevatkm]

Ohh, Thank you @turekv.