Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Site author should utilize author reference #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Site author should utilize author reference #155

wants to merge 2 commits into from

Conversation

pathawks
Copy link
Member

Fixes #112

/cc: @GarthDB

@pathawks pathawks added this to the v1.0.0 milestone Jan 15, 2017
@GarthDB
Copy link
Contributor

GarthDB commented Jan 17, 2017

Sweet - looking forward to getting this fixed.

benbalter
benbalter reviewed Feb 16, 2017
View reviewed changes
Copy link
Contributor

@benbalter benbalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests, otherwise, looking good...

@pathawks pathawks mentioned this pull request Jul 5, 2017
Open
@parkr
Copy link
Member

parkr commented Jul 5, 2017

Tests should cover the following cases:

  1. Where site.authors is nil
  2. Where site.authors is an array
  3. Where site.authors is a hash

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benbalter benbalter benbalter left review comments

Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pathawks @GarthDB @parkr @benbalter @DirtyF