-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Output feed links for collections #254
base: master
Are you sure you want to change the base?
Output feed links for collections #254
Conversation
I'm open to discussion regarding this PR because it is a breaking change (an improvement in most cases, but still). Should
Feel free to give your input on this, I'd be happy to implement it and update the PR. |
Since I need this, I went ahead and made the helper collection- and category-aware. For full backwards compatibility, the new possibilities are all 'opt-in'.
I'll merge this and feed title PRs in my repo so you can try it out —and I can start using it right away. Feel free to give me some feedback if you have any! |
89dfa7f
to
f3941ca
Compare
f3941ca
to
4d58045
Compare
I've updated my pull request to include the latest changes from jekyll-feed master. |
Hi there, is there anything blocking this PR from being merged? I'll gladly update it if needed, just let me know what needs to be improved. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some changes..
As recommended by @ashmaroli Co-Authored-By: goulvench <goulvench@gmail.com>
Recommended by @ashmaroli
Thanks @ashmaroli for spotting that one! Co-Authored-By: goulvench <goulvench@gmail.com>
@goulvench Thank you very much for addressing all of my concerns. I recently learned that YAML parses feed:
collections:
collection:
categories:
- no
- false |
@ashmaroli That's an edge case, can we address this in a specific issue, but it's how YAML works, so best to avoid naming your categories as boolean. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
This needs to have conflicts resolved.. |
Hi, I'd love to see this land in core but it's been more than 20 months since I opened this PR and I don't have time to work on it at the moment. Feel free to implement this in some way, fix the conflicts yourselves, or simply close this PR. |
Dismissing approval due to complex conflicts
Makes
{% feed_meta %}
generate a link for every collection.All meta links have the same title at the moment, which is not good. But if my previous PR is accepted, it's just a matter of replacing
:title => title,
with:title => generator.feed_title(:collection => collection, :category => category)
(and removing thetitle
method frommeta-tag.rb
).If there's a better way of grabbing a reference to the generator from meta-tag, I'd love to hear about it.