-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Guard against invalid or missing URLs #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with an invalid path for page.image
with image: .\wrong\path
There's no warning on the console, the wrong path is included in the generated page metadata :
<meta property="og:image" content="http://localhost:4000/.%5Cwrong%5Cpath" />
{"@context":"http://schema.org","@type":"BlogPosting","headline":"Welcome to Jekyll!","image":"http://localhost:4000/.%5Cwrong%5Cpath","…
@DirtyF what would you expect the behavior to be? My intention here was to prevent the build from failing due to invalid or missing URLs. If a user provides an invalid URL right now, we output it to the best of our ability, even if it's wrong (or isn't live, etc.). |
@benbalter OK then it's fine, you're right people are responsible for what they enter and can rely on tools like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Image Invalid path does not prevent the site from buidling.
Fixes #198.