Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Twitter Image and Title #330

Merged
merged 2 commits into from
Feb 16, 2019
Merged

Twitter Image and Title #330

merged 2 commits into from
Feb 16, 2019

Conversation

scottwater
Copy link
Contributor

I noticed Twitter is no longer pulling the image from og:image.

This change adds the twitter:image meta tag if an image exists on the post.

It also adds the twitter:title meta tag as well.

@DirtyF
Copy link
Member

DirtyF commented Feb 14, 2019

Just tested https://jekyllrb.com/news/2018/11/04/jekyll-3-8-5-released/ on https://cards-dev.twitter.com/validator, and it does show the og:image.

@scottwater
Copy link
Contributor Author

@DirtyF Yes, I can see that image is working. My guess is there is something going on with caching or priority in the image look up. I had an example ready to send you which showed the how my fix worked, but when I double checked Twitter did pick up the og:image but it was missing the first time.

I will see if I can create a more definitive demo.

Having said that, either way, it still feels like a good idea to set the twitter:image and twitter:title.

Thanks,
Scott

@scottwater
Copy link
Contributor Author

I have not been able to duplicate this issue again, but I still believe these changes are helpful long term.

@mattr-
Copy link
Member

mattr- commented Feb 16, 2019

OpenGraph is listed as a fallback on twitter's site so I'm happy to see us provide first class support for this. Especially since they keep breaking it. 😐

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 7898489 into jekyll:master Feb 16, 2019
jekyllbot added a commit that referenced this pull request Feb 16, 2019
@jekyll jekyll locked and limited conversation to collaborators Feb 16, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants