Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Output regenerated file paths to terminal #57

Merged
merged 3 commits into from
Dec 2, 2017

Conversation

ashmaroli
Copy link
Member

With this, the plugin outputs the full path(s) of the regenerated files, in addition to the existing total count of regenerated files

@DirtyF DirtyF requested a review from a team October 24, 2017 08:24
@DirtyF
Copy link
Member

DirtyF commented Oct 24, 2017

current output:

      Regenerating: 1 file(s) changed at 2017-10-24 11:19:46
                    /Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site/css/main.scss
                    ...done in 0.116786 seconds.

@ashmaroli could we only display the relative path to the source directory like we already do for error messages?

[2017-10-24 11:22:16] ERROR `/favicon.ico' not found.

coherent output:

      Regenerating: 1 file(s) changed at 2017-10-24 11:19:46
                    '/css/main.scss'
                    ...done in 0.116786 seconds.

@ashmaroli
Copy link
Member Author

could we only display the relative path to the source directory

That's a good idea.. cleaner output, definitely.
But, I opted for the full-path in sync with how the paths for config-file, source and destination were output..

Configuration file: /Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site/_config.yml
            Source: /Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site
       Destination: /Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 0.914 seconds.
 Auto-regeneration: enabled for '/Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site'
    Server address: http://127.0.0.1:4000/
  Server running... press ctrl-c to stop.
      Regenerating: 1 file(s) changed at 2017-10-24 11:19:46
                    /Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site/css/main.scss
                    ...done in 0.116786 seconds.

But that said, I like the relative_path idea more..


Instead of wrapping the path in single-quotes, may I embellish with a padded-asterix?

Configuration file: /Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site/_config.yml
            Source: /Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site
       Destination: /Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 0.914 seconds.
 Auto-regeneration: enabled for '/Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site'
    Server address: http://127.0.0.1:4000/
  Server running... press ctrl-c to stop.
      Regenerating: 3 file(s) changed at 2017-10-24 14:19:46
                     * /about.md
                     * /index.md
                     * /css/main.scss
                    ...done in 0.216786 seconds.

@DirtyF
Copy link
Member

DirtyF commented Oct 24, 2017

Instead of wrapping the path in single-quotes, may I embellish with a padded-asterix?

We're not in Markdown but in console mode, asterix has a different meaning and adds confusion here.

As for the single-quotes, I was just trying to be coherent but maybe we don't need them at all, we don't add anything in the profile option.

Configuration file: _config.yml
Configuration file: _config_local.yml
....
Filename                                                                            | Count |   Bytes |  Time
------------------------------------------------------------------------------------+-------+---------+------
feed.xml                                                                            |     1 | 220.19K | 2.217
sitemap.xml                                                                         |     1 |   3.15K | 1.146

Let's just go plain and simple. We can deal with style output in a different PR like we discussed before for colors.

@DirtyF
Copy link
Member

DirtyF commented Oct 24, 2017

      Regenerating: 1 file(s) changed at 2017-10-24 13:48:00
                    /_posts/2014-08-08-welcome-to-jekyll.markdown
                    ...done in 0.181475 seconds.

🙌 @ashmaroli

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@mattr-
Copy link
Member

mattr- commented Oct 24, 2017

If we're going to print the source dir relative paths for each file regenerated, let's remove the ellipsis as well.

@DirtyF
Copy link
Member

DirtyF commented Oct 24, 2017

We could go even more compact:

Regenerating: 3 file(s) changed at 2017-10-24 13:48:00
                    /_posts/2017-10-08-welcome-to-jekyll.markdown (0.181475 seconds)
                    /_posts/2016-09-07-another-post.markdown (0.201475 seconds)
                    /_posts/2015-08-06-really-lont-article.markdown (0.181475 seconds)

@mattr-
Copy link
Member

mattr- commented Oct 24, 2017

Yup, could definitely do that. My preference is the summary line at the end but I'll let somebody else decide. 😂

@parkr
Copy link
Member

parkr commented Oct 24, 2017

What does the output Look Like, when you have the —verbose flag set? jekyll serve —verbose

@DirtyF
Copy link
Member

DirtyF commented Oct 24, 2017

currently:

...
 Server running... press ctrl-c to stop.
      Regenerating: 1 file(s) changed at 2017-10-24 16:51:57
                    /_posts/2014-08-08-welcome-to-jekyll.markdown
           Reading: _posts/2014-08-08-welcome-to-jekyll copie 5.markdown
           Reading: _posts/2014-08-08-welcome-to-jekyll copie 4.markdown
           Reading: _posts/2014-08-08-welcome-to-jekyll.markdown
           Reading: _posts/2014-08-08-welcome-to-jekyll copie 2.markdown
           Reading: _posts/2014-08-08-welcome-to-jekyll copie 3.markdown
           Reading: _posts/2014-08-08-welcome-to-jekyll copie.markdown
         Rendering: _posts/2014-08-08-welcome-to-jekyll copie 2.markdown
  Pre-Render Hooks: _posts/2014-08-08-welcome-to-jekyll copie 2.markdown
  Rendering Liquid: _posts/2014-08-08-welcome-to-jekyll copie 2.markdown
         Requiring: rouge
...
  Rendering Markup: css/main.scss
                    ...done in 0.200121 seconds.

@ashmaroli
Copy link
Member Author

let's remove the ellipsis as well

I kinda liked seeing the ellipsis.. sorta like "...and cut! Its a wrap, folks!" No..?

We could go even more compact

Honestly, I don't know how the suggested example can be implemented, given that we've an Array of path strings.. so leaving that for a future PR..

What does the output look like, when you have the --verbose flag set?

The messages are logged at level: info, so its pretty much the same as illustrated in Frank's code blocks. So, @parkr, do you want me to drop the trailing / ?

@DirtyF
Copy link
Member

DirtyF commented Oct 24, 2017

do you want me to drop the trailing / ?

Regenerating: 1 file(s) changed at 2017-10-24 16:51:57
                    _posts/2014-08-08-welcome-to-jekyll.markdown
           Reading: _posts/2014-08-08-welcome-to-jekyll.markdown

It would certainly look more coherent.

@pluehne pluehne mentioned this pull request Oct 30, 2017
1 task
@DirtyF
Copy link
Member

DirtyF commented Dec 2, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit fb71cb8 into jekyll:master Dec 2, 2017
jekyllbot added a commit that referenced this pull request Dec 2, 2017
@ashmaroli ashmaroli deleted the output-regen-path branch December 3, 2017 02:09
@jekyll jekyll locked and limited conversation to collaborators Apr 25, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants