-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Output regenerated file paths to terminal #57
Conversation
2383a61
to
5491e8c
Compare
current output: Regenerating: 1 file(s) changed at 2017-10-24 11:19:46
/Users/frank/code/jekyll/plugins/jekyll-watch/spec/test-site/css/main.scss
...done in 0.116786 seconds. @ashmaroli could we only display the relative path to the source directory like we already do for error messages? [2017-10-24 11:22:16] ERROR `/favicon.ico' not found. coherent output: Regenerating: 1 file(s) changed at 2017-10-24 11:19:46
'/css/main.scss'
...done in 0.116786 seconds. |
That's a good idea.. cleaner output, definitely.
But that said, I like the relative_path idea more.. Instead of wrapping the path in single-quotes, may I embellish with a padded-asterix?
|
We're not in Markdown but in console mode, asterix has a different meaning and adds confusion here. As for the single-quotes, I was just trying to be coherent but maybe we don't need them at all, we don't add anything in the profile option.
Let's just go plain and simple. We can deal with style output in a different PR like we discussed before for colors. |
Regenerating: 1 file(s) changed at 2017-10-24 13:48:00
/_posts/2014-08-08-welcome-to-jekyll.markdown
...done in 0.181475 seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
If we're going to print the source dir relative paths for each file regenerated, let's remove the ellipsis as well. |
We could go even more compact:
|
Yup, could definitely do that. My preference is the summary line at the end but I'll let somebody else decide. 😂 |
What does the output Look Like, when you have the |
currently: ...
Server running... press ctrl-c to stop.
Regenerating: 1 file(s) changed at 2017-10-24 16:51:57
/_posts/2014-08-08-welcome-to-jekyll.markdown
Reading: _posts/2014-08-08-welcome-to-jekyll copie 5.markdown
Reading: _posts/2014-08-08-welcome-to-jekyll copie 4.markdown
Reading: _posts/2014-08-08-welcome-to-jekyll.markdown
Reading: _posts/2014-08-08-welcome-to-jekyll copie 2.markdown
Reading: _posts/2014-08-08-welcome-to-jekyll copie 3.markdown
Reading: _posts/2014-08-08-welcome-to-jekyll copie.markdown
Rendering: _posts/2014-08-08-welcome-to-jekyll copie 2.markdown
Pre-Render Hooks: _posts/2014-08-08-welcome-to-jekyll copie 2.markdown
Rendering Liquid: _posts/2014-08-08-welcome-to-jekyll copie 2.markdown
Requiring: rouge
...
Rendering Markup: css/main.scss
...done in 0.200121 seconds. |
I kinda liked seeing the ellipsis.. sorta like "...and cut! Its a wrap, folks!" No..?
Honestly, I don't know how the suggested example can be implemented, given that we've an Array of path strings.. so leaving that for a future PR..
The messages are logged at |
Regenerating: 1 file(s) changed at 2017-10-24 16:51:57
_posts/2014-08-08-welcome-to-jekyll.markdown
Reading: _posts/2014-08-08-welcome-to-jekyll.markdown It would certainly look more coherent. |
@jekyllbot: merge +minor |
With this, the plugin outputs the full path(s) of the regenerated files, in addition to the existing total count of regenerated files