Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix false positives in typing.Protocol #313

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pm3512
Copy link

@pm3512 pm3512 commented May 7, 2023

Description

Adds the ast_scope package and uses scoping information to find functions in subclasses of typing.Protocol and mark them and their arguments as used.

Related Issue

Resolves #309

Checklist:

  • I have updated the documentation in the README.md file or my changes don't require an update.
  • I have added an entry in CHANGELOG.md.
  • I have added or adapted tests to cover my changes.
  • I have run tox -e fix-style to format my code and checked the result with tox -e style.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Merging #313 (d6c182e) into main (e2e84d0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   98.94%   98.98%   +0.03%     
==========================================
  Files          21       21              
  Lines         665      690      +25     
==========================================
+ Hits          658      683      +25     
  Misses          7        7              
Impacted Files Coverage Δ
vulture/core.py 98.63% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@btschroer
Copy link

Nice 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong processing of typing.Protocol
3 participants