Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update color to comply to Web Content Accessibility Guidelines #37

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Update color to comply to Web Content Accessibility Guidelines #37

merged 1 commit into from
Sep 2, 2019

Conversation

yne
Copy link
Contributor

@yne yne commented Sep 2, 2019 •
edited
Loading

The default primary and secondary color is not dark enought for accessibility check. see:

image

According to https://dequeuniversity.com/rules/axe/3.1/color-contrast
color changed from #1a9f60 to #14854F for .primary
color changed from #7e818b to #747681 for .secondary
so we get:

image

@yne yne changed the title Comply --color-primary to Web Content Accessibility Guidelines Update color to Comply to Web Content Accessibility Guidelines Sep 2, 2019
@yne yne changed the title Update color to Comply to Web Content Accessibility Guidelines Update color to comply to Web Content Accessibility Guidelines Sep 2, 2019
@jenil
Copy link
Owner

jenil commented Sep 2, 2019

Thanks!

@jenil jenil merged commit df72799 into jenil:master Sep 2, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jenil jenil jenil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yne @jenil