Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add dark mode to jx-docs website #3053

Merged
merged 3 commits into from
Sep 17, 2020
Merged

feat: add dark mode to jx-docs website #3053

merged 3 commits into from
Sep 17, 2020

Conversation

ysahil97
Copy link
Contributor

@ysahil97 ysahil97 commented Sep 9, 2020

fixes #2877

@jenkins-x-bot
Copy link
Contributor

Hi @ysahil97. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ankitm123
Copy link
Member

/ok-to-test

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-3053 here

@ankitm123
Copy link
Member

@ysahil97 great work 💯
Would be nice to fix the issue with dark mode not being persisted when navigating from one page to the other.

@ankitm123
Copy link
Member

@MarckK any idea why the build is failing?

@MarckK
Copy link
Member

MarckK commented Sep 16, 2020

/retest

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-3053 here

@MarckK
Copy link
Member

MarckK commented Sep 16, 2020

Great work, @ysahil97! This looks good 👍

Should the toggle be moved over to the right on the top nav bar, to be with the site navigation links, and not the branding links of Jenkins X and CDFoundation?
Screenshot 2020-09-16 at 09 29 31

We could put it next to the language ('English') toggle link? It could be on either side, but next to the Search box may look better.

@ysahil97
Copy link
Contributor Author

Sure @MarckK, let's place it in between english toggle link and search box.

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-3053 here

@MarckK
Copy link
Member

MarckK commented Sep 17, 2020

This looks good! Thank you, @ysahil97

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarckK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-3053 here

@jenkins-x-bot jenkins-x-bot merged commit 07779cc into jenkins-x:master Sep 17, 2020
@ysahil97 ysahil97 deleted the dark-mode branch September 17, 2020 09:12
@abitrolly abitrolly mentioned this pull request Oct 30, 2021
Closed
26 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ankitm123 ankitm123 ankitm123 left review comments

Assignees

@MarckK MarckK

Labels
approved lgtm ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Add a dark mode to the website
4 participants
@ysahil97 @jenkins-x-bot @ankitm123 @MarckK