Installing plugins was flaky #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it has been observed that plugin installation was flaky as the installation clicked the button but then immediatly looked like there where no plugins to update. the HAR showed that the response to post the install had not finished and then the call to the UpdateCenter was made and as the previous call had not completed, there where no installation jobs present and so deeemed that there was nothing to wait for. the check then fails as the plugin has not infact been installed ``` java.lang.IllegalArgumentException: workflow-multibranch plugin not installed at org.jenkinsci.test.acceptance.po.Plugin.<init>(Plugin.java:49) at org.jenkinsci.test.acceptance.po.Jenkins.getPlugin(Jenkins.java:214) at org.jenkinsci.test.acceptance.po.UpdateCenter.waitForInstallationToComplete(UpdateCenter.java:98) at org.jenkinsci.test.acceptance.po.PluginManager.installPlugins(PluginManager.java:259) at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.installPlugins(WithPlugins.java:191) ```
jtnord
commented
Aug 9, 2023
| } | ||
| } | ||
| } | ||
|
|
||
| // Jenkins will be restarted if necessary | ||
| boolean hasBeenRestarted = new UpdateCenter(jenkins).waitForInstallationToComplete(specs); | ||
| if (!hasBeenRestarted && specs.length > 0 && jenkins.getVersion().isNewerThan(new VersionNumber("2.188"))) { |
There was a problem hiding this comment.
supported Jenkins for the ath are passed this version now, so removed this condition whilst I was here.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it has been observed that plugin installation was flaky as the installation clicked the button but then immediately looked like there where no plugins to update.
the HAR showed that the response to the install POST had not finished and then the GET call to the UpdateCenter was made. As the previous call had not completed, there where no installation jobs present and so deemed that there was nothing to wait for. the check then fails as the plugin has not infact been installed
e.g.
clicking anything that changes URL based on javascript (or does anything dynamic in JS) is going to be flaky - I think it is time to revert 5606d3b
Testing done
None.
Submitter checklist