Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test on Java 21 #1324

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Test on Java 21 #1324

merged 1 commit into from
Aug 15, 2023

Conversation

basil
Copy link
Member

@basil basil commented Aug 12, 2023

Fixes #1320. I have retained a Java 11 build for the LTS line in order to alleviate concerns that we may accidentally begin to start relying on the behavior of newer Java versions in plugins. If this occurs, then shortly after the plugin is released its Java 11 tests would begin to fail on the LTS line (assuming the plugin does not require a weekly release, which is only the case for a small number of plugins). True, the plugin would have to be released to users before the issue is detected in this repository, but that is already a problem even today since there is no convenient way to run ATH or PCT from within a plugin PR build.

@timja
Copy link
Member

timja commented Aug 12, 2023

Looks like adding JENKINS_OPTS=--enable-future-java is needed.

@basil
Copy link
Member Author

basil commented Aug 12, 2023

Note that this PR is not yet ready for review.

@basil
Copy link
Member Author

basil commented Aug 13, 2023

@NotMyFault
Copy link
Member

Depends on jenkinsci/jenkins#8365 and jglick/simple-maven-project-with-tests#34.

If we just need a repository with tests, we could replace Jesse's repo in favor of https://github.com/jenkinsci/hello-world-maven-builder, which is already used in another test case.
I created that repo under the org for ease of accessibility when updating a test case to support Java 17.

@basil
Copy link
Member Author

basil commented Aug 13, 2023

@NotMyFault Note that this PR is not yet ready for review.

@basil basil closed this Aug 13, 2023
@basil basil reopened this Aug 15, 2023
@basil basil marked this pull request as ready for review August 15, 2023 18:21
@timja timja merged commit 27debef into jenkinsci:master Aug 15, 2023
@basil basil deleted the java21 branch August 16, 2023 17:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test on Java 21
3 participants