Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update missing tool installation for maven 3.9.4 #1357

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Sep 8, 2023

amends #1327 to provide the required metadata

Without the metadata all the changed tests became flaky or failed reliably (depending on infrastructure setup) due to requiring a successful update from the update center.

Testing done

none

Submitter checklist

Preview Give feedback

ammends #1327 to provide the required metadata
@jtnord jtnord requested review from NotMyFault and timja September 8, 2023 09:56
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know! I wasn't aware of the regression, tests were successful in my initial PR

@jtnord jtnord enabled auto-merge (squash) September 8, 2023 10:21
@jtnord jtnord merged commit ae19d1e into master Sep 8, 2023
@jtnord jtnord deleted the jtnord-patch-1 branch September 8, 2023 10:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants