Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix folders tests #1394

Merged
merged 1 commit into from
Oct 21, 2023
Merged

fix folders tests #1394

merged 1 commit into from
Oct 21, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Oct 20, 2023

after switching folders to use a confirmation dialog the tests no longer work for lts where still the browser native dialogs are used.

Testing done

Submitter checklist

Preview Give feedback

after switching folders to use a confirmation dialog the tests
no longer work for lts where still the browser native dialogs are used.
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if ATH is expected to handle the older version of the plugin as well.

@NotMyFault NotMyFault added the bug label Oct 21, 2023
@NotMyFault NotMyFault merged commit 702c71f into jenkinsci:master Oct 21, 2023
@timja
Copy link
Member

timja commented Oct 22, 2023

Not sure if ATH is expected to handle the older version of the plugin as well.

We wouldn't generally do that, unless the newer change isn't available on the active LTS line then we would need to as we test LTS and weekly

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants