Remove WorkflowPluginTest#sshGitInsideDocker
#1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was using multiple unmaintained Docker images from the 2017 era, and after trying for a few hours I could not get it to reliably pass on CI using recent Ubuntu 24.04 LTS images (although I did get it working locally with some acrobatics). Since the code under test represents a deprecated use case and the test machinery is extremely complex (Docker within Docker within Docker) and hard to maintain, I am judging this as too low a value to justify the cost and deleting this test. If someone feels strongly about keeping this test, feel free to revert this change and get it to work on a recent container image.