Enable 'Build has no changes' assertion in FreestyleJobTest #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assertion was disabled due to user interface change that has been modified in Jenkins 2.459 to again report when the build has no changes. https://issues.jenkins.io/browse/JENKINS-73168 fixes it in Jenkins 2.459. jenkinsci#1548 is the issue to remove the workaround. Revert part of "Work around JENKINS-73034 (jenkinsci#1547)" Tested by running the modified test with JENKINS_WAR set to a copy of the 2.459 Jenkins war file. This reverts part of commit 4d71d1b.
MarkEWaite
changed the title
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable "Build has no changes" assertion in FreestyleJobTest
Assertion was disabled due to user interface change that has been modified in Jenkins 2.459 to again report when the build has no changes.
JENKINS-73168 fixes it in Jenkins 2.459.
Fixes #1548
This reverts part of commit 4d71d1b.
Testing done
Tested by running the modified test with JENKINS_WAR set to a copy of the 2.459 Jenkins war file.
Submitter checklist