Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adjust to removal of idle executors #1605

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

mawinter69
Copy link
Contributor

with the removal of idle executors (jenkinsci/jenkins#9177) we no longer have a big table so find the corresponding div for the headers. As executors are only shown while building remove the check for shown executors completely.

fixes #1603

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

with the removal of idle executors we no longer have a big table so find
the corresponding div for the headers. As executors are only shown while
building remove the check for shown executors completely.
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank!

@timja timja added the bug label Jun 24, 2024
@timja timja enabled auto-merge (squash) June 24, 2024 12:05
auto-merge was automatically disabled June 24, 2024 12:25

Head branch was pushed to by a user without write access

@mawinter69
Copy link
Contributor Author

the change is not backward compatible so it will not work on 2.462

@timja timja enabled auto-merge (squash) June 24, 2024 12:28
@timja timja disabled auto-merge June 24, 2024 12:28
@timja
Copy link
Member

timja commented Jun 24, 2024

the change is not backward compatible so it will not work on 2.462

We also test against LTS, so a compatible version will need to be adapted to be compatible with:

  • Latest weekly
  • Latest LTS

No problem if not compatible with 2.462

@mawinter69 mawinter69 marked this pull request as draft June 24, 2024 12:32
@mawinter69 mawinter69 marked this pull request as ready for review June 24, 2024 16:22
@timja timja merged commit dea99c1 into jenkinsci:master Jun 24, 2024
24 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DashboardViewPluginTest.configureDashboardFilterBuildExecutors fails on core 2.463
2 participants