Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adapt the OicAuthPluginTest to the changes in the describables #1724

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

fcojfernandez
Copy link
Member

See #1723

jenkinsci/oic-auth-plugin#399 changes the describables in the plugin, so the OicAuthPluginTest must be adapted. As this test has been there for less than 2 weeks, I don't see any need to keep any backward compatibility checking the plugin version.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite merged commit a23ad46 into jenkinsci:master Sep 23, 2024
25 checks passed
@fcojfernandez fcojfernandez deleted the issue-1723 branch September 24, 2024 07:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapt OicAuthPluginTest to https://github.com/jenkinsci/oic-auth-plugin/pull/399
3 participants