Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix selector broken by case change in plugin #622

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

fqueiruga
Copy link
Contributor

postbuildscript-2.11.0 changed the string "Execute Scripts" to "Execute scripts" (see commit). This broke the following tests

  • PostBuildScriptPluginTest#run_post_build_step
  • PostBuildScriptPluginTest#skip_for_jobs_that_succeeded

This PR fixes the selector

- postbuildscript-2.11.0 changed the string "Execute Scripts" to "Execute scripts" and this broke the plugin tests.
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to add both values (old and new) then the plugin tests will continue to work with the previous version as well?

@fqueiruga
Copy link
Contributor Author

You're right, done.

@timja
Copy link
Member

timja commented Nov 27, 2020

Wouldn't it be better to add both values (old and new) then the plugin tests will continue to work with the previous version as well?

not really sure why you would want to verify old versions of this plugin? unless it's core baseline is really new you would always be validating the latest version I would expect

@fqueiruga fqueiruga requested a review from uhafner November 27, 2020 13:14
@uhafner
Copy link
Member

uhafner commented Nov 27, 2020

I don't know if that makes sense for that particular plugin. But in general, if the new release of this plugin requires a newer core version, then a depending plugin will still pick up the old version of the plugin in its UI tests.

@jtnord jtnord added the fix label Nov 27, 2020
@timja
Copy link
Member

timja commented Dec 1, 2020

@timja timja merged commit 9eb2cbe into jenkinsci:master Dec 1, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants