Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[JENKINS-62867] Fixes job filtering selection in views #624

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

alecharp
Copy link
Member

@alecharp alecharp commented Dec 1, 2020

JENKINS-62867

Since 2.239 and jenkinsci/jenkins#4466, the job filter has its own view.

Since  2.239 and jenkinsci/jenkins#4466, the job filter has its own view.
Copy link
Contributor

@MRamonLeon MRamonLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to keep the old behavior to keep backward compatibility with old versions of the plugin. Some if with or similar:

jenkins.getPlugin("dashboard_view").getVersion().isOlderThan(new VersionNumber("x.y.z"))

@timja
Copy link
Member

timja commented Dec 1, 2020

I think we have to keep the old behavior to keep backward compatibility with old versions of the plugin. Some if with or similar:

jenkins.getPlugin("dashboard_view").getVersion().isOlderThan(new VersionNumber("x.y.z"))

this is core that changed not a plugin, but yes that could be done, not sure why you would want to though, this is now in 2 LTS versions, (2.263.1 and 2.249.x).

@alecharp
Copy link
Member Author

alecharp commented Dec 2, 2020

Yes, this is a core change, not a plugin one. Getting the core version the test is running on from a PageArea class is not simple it seems.

@timja
Copy link
Member

timja commented Dec 2, 2020

Test is passing

@timja timja closed this Dec 2, 2020
@timja timja reopened this Dec 2, 2020
@timja timja merged commit a6e2c66 into jenkinsci:master Dec 2, 2020
@alecharp alecharp deleted the JENKINS-62867 branch December 2, 2020 09:00
@jtnord jtnord added the fix label Dec 3, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants