Make check of logged-in user independent of UI

[fcojfernandez]

Making the check of the logged user using Jenkins API instead the UI, so the check is more robust in case something is not well rendered.

@bmunozm @EstherAF

@jtnord I think you're the new maintainer?

[jglick]

IIUC uses

acceptance-test-harness/src/main/java/org/jenkinsci/test/acceptance/po/User.java

Lines 45 to 56 in ca473c8

	super(context, context.url("me/"));
	}
	public User(Jenkins context, String name) {
	super(context, context.url("user/%s/", name));
	}
	private void load() {
	if (id != null) return;
	try {
	JsonNode json = getJson();
	id = json.get("id").asText();

[fcojfernandez]

When the user is not valid, the User object is not null but its id is. User seems to be null only if there has been no attempt to login. That made LdapPluginTest failed in a couple of tests.

Already Fixed

[jglick]

or just

Suggested change

	return currentUser != null && currentUser.id() != null && currentUser.id().equals(user);
	return currentUser != null && user.equals(currentUser.id());

I suppose

[fcojfernandez]

that was my first intention, but after a search I couldn't be 100% sure that user will be always non-null. I can commit the suggestion if you prefer

[amuniz]

There are currently 264 test failures in master, this PR has 330. Is the diff because of this change?

[fcojfernandez]

After analysing the failures (and I'm not experienced on the plugins whose tests are failing and I might be wrong):

• None of those tests are checking the logged user, that is what is changed in this PR
• Only AuditTrailPluginTest and MissionControlTest are failing in local. The rest of them are passing using the latest LTS in a local execution. Why are the tests failing then? I don't know and I don't have knowledge about those plugins to know if there's something in the test per se (my guess)

The details:

1. PlotPluginPropertiesTest: Not using either Login.doSuccessfullLogin or Matchers.hasLoggedInUser / Matchers.loggedInAs. Local execution with latest LTS is OK
2. JobDslPluginTest: Not using either Login.doSuccessfullLogin or Matchers.hasLoggedInUser / Matchers.loggedInAs. Local execution with latest LTS is OK
3. PrioritySorterPluginTest: Not using either Login.doSuccessfullLogin or Matchers.hasLoggedInUser / Matchers.loggedInAs. Local execution with latest LTS is OK
4. MissionControlTest: Not using either Login.doSuccessfullLogin or Matchers.hasLoggedInUser / Matchers.loggedInAs. Local execution with latest LTS is failing as well, but the tests are executed as anonymous user. NOT RELATED
5. FtpPublishPluginTest: Not using either Login.doSuccessfullLogin or Matchers.hasLoggedInUser / Matchers.loggedInAs. Local execution with latest LTS is OK
6. PlotPluginXmlTest: Not using either Login.doSuccessfullLogin or Matchers.hasLoggedInUser / Matchers.loggedInAs. Local execution with latest LTS is OK
7. AuditTrailPluginTest: Not using either Login.doSuccessfullLogin or Matchers.hasLoggedInUser / Matchers.loggedInAs. Local execution with latest LTS is is failing as well, but the tests are executed as anonymous user. NOT RELATED
8. core.BuildHistoryTest: Not using either Login.doSuccessfullLogin or Matchers.hasLoggedInUser / Matchers.loggedInAs. Local execution with latest LTS is OK

[timja]

Plot plugin is known to be broken on weeklies. It should probably be removed from ATH, I don't think it meets the threshold for what should be here.

[amuniz]

Great. Thanks @fcojfernandez! I'm merging now.