reduce flakiness of doSuccesfulLogin #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
force-pushed
the
flaky-logins
branch
from
ac3dafa to
40f98e3
Compare
since jenkinsci@ebdd746 it doesn't rely on path anyway
jtnord
reviewed
Feb 19, 2021
jtnord
reviewed
Feb 19, 2021
| Assert.assertThat(this, loggedInAs(user)); | ||
| waitFor().withTimeout(30, TimeUnit.SECONDS).until(() -> { | ||
| assertThat(this, not(hasInvalidLoginInformation())); // login hasn't failed | ||
| return ExpectedConditions.visibilityOfElementLocated(by.id("jenkins")); // redirect has happened |
There was a problem hiding this comment.
I am wondering if this can happen on other places where we also use clickAndWaitToBecomeStale or until(CapybaraPortingLayerImpl::isStale);
This could likely be the cause (and the fix) of the race condition on creating a new Folder that has been observed a a few times. https://issues.jenkins.io/browse/JENKINS-64358
There was a problem hiding this comment.
Yes it looks like the same class of issue.
jtnord
approved these changes
Feb 19, 2021
amuniz
approved these changes
Feb 19, 2021
Vlatombe
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing regularly flakiness in my ATH such as
I think in some cases the current check is not enough and the navigation happens before the login is really completed.
While working on this area, I notices
doLoginDespiteNoPathswas useless sincedoLoginhas been changed to not use path since ebdd746. So I deprecated it and removed calls I could find in this ATH.