Fix driver location support when run on windows and cygwin is in the path. #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if Cygwin was on the path `which` would work and return a cygwin path -
and those are not executable on windows..
e.g. fix the following:
```
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
2.293 s <<< FAILURE! - in core.FormValidationTest
[ERROR] validate(core.FormValidationTest) Time elapsed: 2.254 s <<<
ERROR!
com.google.inject.ProvisionException:
Unable to provision, see the following errors:
1) Error in custom provider, java.lang.IllegalStateException: The driver
executable does not exist: C:\cygdrive\c\tools\geckodriver
at
org.jenkinsci.test.acceptance.FallbackConfig.createWebDriver(FallbackConfig.java:293)
(via modules: org.jenkinsci.test.acceptance.guice.World ->
com.google.inject.util.Modules$OverrideModule ->
com.google.inject.util.Modules$OverrideModule ->
org.jenkinsci.test.acceptance.FallbackConfig)
at
org.jenkinsci.test.acceptance.FallbackConfig.createWebDriver(FallbackConfig.java:293)
(via modules: org.jenkinsci.test.acceptance.guice.World ->
com.google.inject.util.Modules$OverrideModule ->
com.google.inject.util.Modules$OverrideModule ->
org.jenkinsci.test.acceptance.FallbackConfig)
while locating org.openqa.selenium.WebDriver
```
jtnord
commented
Feb 19, 2021
src/main/java/org/jenkinsci/test/acceptance/FallbackConfig.java
Outdated
Show resolved
Hide resolved
timja
approved these changes
Feb 19, 2021
Vlatombe
approved these changes
Feb 22, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if Cygwin was on the path
whichwould work and return a cygwin path -and those are not executable on windows..
e.g. fix the following: