-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add the ability to configure the network used by Docker fixtures using DOCKER_FIXTURES_NETWORK
#655
Add the ability to configure the network used by Docker fixtures using DOCKER_FIXTURES_NETWORK
#655
Conversation
It is a bit dificult to compare with |
This is what I am gonna do to properly check this.
|
Ok, so https://ci.jenkins.io/job/Core/job/acceptance-test-harness/view/change-requests/job/PR-655/ should be my baseline once it finishes |
Using https://ci.jenkins.io/blue/organizations/jenkins/Core%2Facceptance-test-harness/detail/PR-655/3/tests as baseline, I have restored the fixtures update, will see |
OK, almost same results but one test failing building docker images, does not seem related, so I will retrigger |
Retriggering solved the unexpected failures but gave a different number of tests, at this point I am convinced I am suffering flakiness and none of the failures are related to my change |
DOCKER_FIXTURES_NETWORK
To pick jenkinsci/docker-fixtures#32 basically.So I can use docker-compose to launch the ATH in a trivially portable way.
This pr should be enough to test the change, I have manually tested this and on my personal CI system