Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add the ability to configure the network used by Docker fixtures using DOCKER_FIXTURES_NETWORK #655

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

raul-arabaolaza
Copy link
Contributor

To pick jenkinsci/docker-fixtures#32 basically.So I can use docker-compose to launch the ATH in a trivially portable way.

This pr should be enough to test the change, I have manually tested this and on my personal CI system

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@raul-arabaolaza
Copy link
Contributor Author

raul-arabaolaza commented Apr 11, 2021

There are 0 new tests failing, 70 existing failing and 72 skipped.

It is a bit dificult to compare with master build as it does not seem to have coherent results, however last master result is 50 failed and other PRs also have 50 failed, so I will review in depth the tests to be sure

@raul-arabaolaza
Copy link
Contributor Author

This is what I am gonna do to properly check this.

  • I will remove the dependency update and let the pr builder to run with just the README update this will give me an accurate baseline
  • Then I will add again the dependency update and compare the results with the previous execution
  • After that thoughts and prayers 😁

@raul-arabaolaza
Copy link
Contributor Author

Ok, so https://ci.jenkins.io/job/Core/job/acceptance-test-harness/view/change-requests/job/PR-655/ should be my baseline once it finishes

@raul-arabaolaza
Copy link
Contributor Author

Using https://ci.jenkins.io/blue/organizations/jenkins/Core%2Facceptance-test-harness/detail/PR-655/3/tests as baseline, I have restored the fixtures update, will see

@raul-arabaolaza
Copy link
Contributor Author

OK, almost same results but one test failing building docker images, does not seem related, so I will retrigger

@raul-arabaolaza
Copy link
Contributor Author

Retriggering solved the unexpected failures but gave a different number of tests, at this point I am convinced I am suffering flakiness and none of the failures are related to my change

@raul-arabaolaza raul-arabaolaza marked this pull request as ready for review April 16, 2021 09:30
@timja timja merged commit 9781988 into jenkinsci:master Apr 21, 2021
@jtnord jtnord changed the title Docker fixtures update to 1.11 Add the ability to configure the network used by Docker fixtures using DOCKER_FIXTURES_NETWORK Apr 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants