Reduce flakiness on plugins check #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've observed this failing with `StaleElementReferenceException` from time to time. I tracked it down to the plugin manager UI dynamic behaviour (DOM elements show up and down) so the initially select element becomes stale after a few milliseconds. There is no way to know if the element will become stale or not, so the only way I found to make this less flaky is by waiting 1 second and retrying, then give up if it fails again.
jtnord
reviewed
Apr 29, 2021
src/main/java/org/jenkinsci/test/acceptance/po/PluginManager.java
Outdated
Show resolved
Hide resolved
jtnord
reviewed
Apr 29, 2021
src/main/java/org/jenkinsci/test/acceptance/po/PluginManager.java
Outdated
Show resolved
Hide resolved
|
Should be better now. |
timja
approved these changes
Apr 29, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed this failing with
StaleElementReferenceExceptionfromtime to time. I tracked it down to the plugin manager UI dynamic
behaviour (DOM elements show up and down) so the initially select
element becomes stale after a few milliseconds.
There is no way to know if the element will become stale or not, so the
only way I found to make this less flaky is by waiting 1 second and
retrying, then give up if it fails again.