Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[JENKINS-65398] Apply matching changes for terminology updates to command-launcher #661

Merged
merged 1 commit into from
May 17, 2021
Merged

[JENKINS-65398] Apply matching changes for terminology updates to command-launcher #661

merged 1 commit into from
May 17, 2021

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented May 17, 2021 •
edited
Loading

Counterpart of jenkinsci/command-launcher-plugin#19, in particular https://github.com/jenkinsci/command-launcher-plugin/pull/19/files#diff-803a375281009efd6b3fc058a7f5874c7404b7dc71d92bdeabd8f81445aa7a97R27

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja merged commit a4e825d into jenkinsci:master May 17, 2021
aHenryJard
aHenryJard approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny to see the full history :)

@Vlatombe Vlatombe deleted the terminology-changes-command-launcher branch May 17, 2021 08:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@twasyl twasyl twasyl approved these changes

@aHenryJard aHenryJard aHenryJard approved these changes

@timja timja timja approved these changes

@bmunozm bmunozm bmunozm approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
Terminology cleanup
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Vlatombe @twasyl @aHenryJard @timja @bmunozm @jtnord