[JENKINS-65587] fix FreestyleJobTest#should_visit_build_with_permalink in latest cores #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k in latest cores
bmunozm
approved these changes
May 20, 2021
jtnord
commented
May 20, 2021
|
|
||
| WebElement successIcon = build.find(By.xpath("//h1/img")); | ||
| assertThat(successIcon.getAttribute("tooltip"), is("Success")); | ||
| String expectedUrl = link.getAttribute("href"); |
There was a problem hiding this comment.
I thought about switching this to match the SVG's title but a quick attempt did not work (and it seems that the SVN has some asynchronous javascript associated with it to manipulate the DOM).
As the Build PageObject already has a permalink option (it does not use the permalink.click though) use that and as the page URL is hard coded check that the permalink link was actually reffering to this page (incase the Permalink regresses in the future)
timja
approved these changes
May 20, 2021
bitwiseman
approved these changes
May 20, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-65587
Test failed in latest cores as the build status icon was no longer an image but an SVG.