Fix checkout over ssh #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -159,7 +160,7 @@ | |||
| StandardCredentials credentials = BitbucketCredentials.lookupCredentials( | |||
| scmSource.getServerUrl(), | |||
| scmSource.getOwner(), | |||
| credentialsId, | |||
| DescriptorImpl.SAME.equals(scmSource.getCheckoutCredentialsId()) ? credentialsId : scmSource.getCheckoutCredentialsId(), | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| @@ -159,7 +160,7 @@ | |||
| StandardCredentials credentials = BitbucketCredentials.lookupCredentials( | |||
| scmSource.getServerUrl(), | |||
| scmSource.getOwner(), | |||
| credentialsId, | |||
| DescriptorImpl.SAME.equals(scmSource.getCheckoutCredentialsId()) ? credentialsId : scmSource.getCheckoutCredentialsId(), | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
|
@MartinHelwig can you please have a look at the merge conflicts? |
|
@lifeofguenter the merge conflicts are resolved. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the checkoutCredentialsId if available so that the credentials are an instance of SSHUserPrivateKey, the protocol switches to ssh and getCloneLink do not fail. This should fix #811
Your checklist for this pull request