Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for multijob: phases as lanes and status for current build #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for multijob: phases as lanes and status for current build #180

wants to merge 1 commit into from

Conversation

lpenz
Copy link

@lpenz lpenz commented Nov 3, 2015

The multijob integration is working as follows:

  • you should order the jobs by phase (new order plugin)
  • when "multijobLanes" is selected in the settings, the "columns" slider disappears, and the jobs will then have a width of 100% / jobs in that phase for the parent multijob
  • you should not mix jobs from different multijobs projects, as they will be mixed up in the view
  • when a new multijob run starts, the view is smart enough to show only the job status for that multijob run (thanks @Brantone for Grouping: Support for MultiJob grouping #98)

Functionally, this implementation looks exactly as I though it should.
I'm do not think it is good enough from a code perspective. I was not able to add any tests, and I think I might be adding an unwanted dependency in some points. Do you have any pointers on that?

@jan-molak
Copy link
Member

Many thanks for your contribution @lpenz , I'll review it as soon as I'm done with the performance issue mentioned in #151

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants