[JENKINS-74977] Require Jenkins 2.452.4, depend on commons compress API plugin

[MarkEWaite]

JENKINS-74977 Require Jenkins 2.452.4, depend on commons compress API plugin

Jenkins 2.489 removes the commons compress library from Jenkins core. This plugin depended on the commons compress library being provided by Jenkins core in order to satisfy the transitive dependency from truezip-driver-zip. Make the plugin depend on commons-compress-api plugin instead of commons-core from Jenkins core so that the plugin can run on Jenkins versions 2.489 and later.

Jenkins 2.452.4 was selected as the minimum Jenkins version because:

• 75% of installations of the most recent release are already running 2.452.4 or newer
• 2.452.4 is a recommended minimum Jenkins version
• 2.452.4 is the release that fixes critical security vulnerability SECURITY-3430
• The commons-compress-api plugin is not available in the plugin BOM until 2.426.x, so some upgrade of the minimum Jenkins version is required. Better to choose a recommended version than an older version

This issue also blocks the update of the Jenkins acceptance test harness to use Jenkins 2.489. The pull request that fails due to the compress artifacts plugin is:

• Update dependency org.jenkins-ci.main:jenkins-war to v2.489 acceptance-test-harness#1860

Also updates the Jenkinsfile to test with Java 17 and Java 21, since Jenkins core releases no longer support Java 11.

Supersedes:

• Bump org.jenkins-ci.plugins:plugin from 4.82 to 4.87 #29

Would very much appreciate a rapid merge and release of this change so that the acceptance test harness can pass again.

Testing done

Confirmed that the 109.v98a_db_d3cb_72c release of the plugin fails when loaded into Jenkins 2.489 after enabling Artifact Management for Builds with the "Compress Artifacts" setting. The Pipeline looks like this:

pipeline {
    agent any
    stages {
	stage('Archive-datefile') {
	    steps {
		sh 'date >> datefile.txt'
		archiveArtifacts artifacts: 'datefile.txt'
	    }
	}
    }
}

Confirmed that the same Pipeline works correctly with the updated version of the plugin from this change.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

The automated test that calls compressor.start() is now modified to never call compressor.stop() because Java 8 and later have modified the Thread.stop() method to always throw an exception when it is called. An Oracle Tecnote describes the details. I took the simple approach and accepted that if the thread were leaked from a test, it would be a very short-lived leak because the test process would end very soon.

[MarkEWaite]

The acceptance test harness with the incremental build passes the 3 tests that were previously failing, but fails a different test (SnippetGeneratorTest). More investigation needed.

I'm unable to duplicate that failure on my local installation.

[MarkEWaite]

@jglick could you approve and merge this pull request in order to resolve JENKINS-74977 and allow the acceptance test harness to use Jenkins 2.479? You're the only person in the @jenkinsci/compress-artifacts-plugin-developers group.

If you prefer, I am also willing to submit an adoption request so that I can merge the pull request. CD is configured, so labeling this as a "bug" and merging it should be enough.

[jonesbusy]

Thanks!

[MarkEWaite]

Thanks for reviewing @jonesbusy and thanks for merging @timja! The acceptance test harness pull request for 2.489 has merged:

• Update dependency org.jenkins-ci.main:jenkins-war to v2.489 acceptance-test-harness#1860