Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: render dark scrollbars in dark mode #511

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

Den-dp
Copy link
Contributor

@Den-dp Den-dp commented Jun 8, 2024

Currently, scrollbars aren't dark in Chrome:

image

Testing done

with this change it will look like this:

image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Den-dp Den-dp requested a review from a team as a code owner June 8, 2024 16:27
@janfaracik
Copy link
Contributor

Tried in Safari/Chrome - looks good to me. Thanks!

@janfaracik janfaracik merged commit 3f58b49 into jenkinsci:master Jun 8, 2024
15 checks passed
@NotMyFault NotMyFault added the bug Something isn't working label Jun 8, 2024
@Den-dp Den-dp deleted the fix/dark-scrollbars branch June 9, 2024 00:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants