Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Documentation - clarify when certain env variables are being set #1527

Merged

Conversation

sliwkr
Copy link
Contributor

@sliwkr sliwkr commented Nov 16, 2023

Highlight that GIT_PREVIOUS_SUCCESSFUL_COMMIT and GIT_PREVIOUS_COMMIT are not being set during the first build for a given git branch. Might save someone else a few headscratches.
Also, this appears to be part of the previous, now-deprecated documentation.

Checklist

  • I have read the CONTRIBUTING doc
  • Documentation in README has been updated as necessary

Types of changes

  • Dependency or infrastructure update

@sliwkr sliwkr requested a review from a team as a code owner November 16, 2023 23:32
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 16, 2023
@sliwkr
Copy link
Contributor Author

sliwkr commented Nov 16, 2023

Also happy for this to be included in another PR if it's not worth having a separate one just for a readme update.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite enabled auto-merge (squash) November 16, 2023 23:44
@MarkEWaite MarkEWaite merged commit f6739cc into jenkinsci:master Nov 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants