Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow tests with containers #1613

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Allow tests with containers #1613

merged 1 commit into from
Jul 29, 2024

Conversation

olamy
Copy link
Member

@olamy olamy commented Jul 29, 2024

JENKINS-xxxxx - summarize pull request in one line

Describe the big picture of your changes here to explain to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, include a link to the issue.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code. If a checkbox or line does not apply to this pull request, delete it. We prefer all checkboxes to be checked before a pull request is merged

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. Delete the items in the list that do not apply

  • Dependency or infrastructure update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Further comments

If this is a relatively large or complex change, start the discussion by explaining why you chose the solution you did and what alternatives you considered.

@olamy olamy requested a review from a team as a code owner July 29, 2024 01:49
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, not a problem. Merging immediately, since a CI job execution will ignore this change

@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Jul 29, 2024
@MarkEWaite MarkEWaite changed the title useContainerAgent to false to be able to use testcontainer for PR https://github.com/jenkinsci/git-plugin/pull/1611 Allow tests with containers Jul 29, 2024
@MarkEWaite MarkEWaite merged commit fbb5d91 into master Jul 29, 2024
3 of 5 checks passed
@MarkEWaite MarkEWaite deleted the container-agent-false branch July 29, 2024 01:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants