Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[JENKINS-57683] Fix class cast exception scanning multibranch pipeline #721

Merged
merged 2 commits into from
May 27, 2019

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented May 26, 2019

JENKINS-57683 - Fix class cast exception scanning multibranch pipeline

PruneStaleBranchTrait implementation did not handle SCMSource which was not a GitSCMSource.
Added a failing test, then fixed the failing test.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes (I won't merge this until I've tested interactively)
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@MarkEWaite MarkEWaite merged commit 7103d59 into jenkinsci:master May 27, 2019
@MarkEWaite MarkEWaite deleted the branch-source-class-cast-fix branch May 27, 2019 00:18
@MarkEWaite MarkEWaite added the bugfix Fixes a bug - used by Release Drafter label Jul 13, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bugfix Fixes a bug - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants