[JENKINS-73133] Adapt GitHub for Jetty 12 (EE 8) #380
Conversation
basil
force-pushed
the
prototype
branch
2 times, most recently
from
671e95c
to
b64cdf2
Compare
basil
changed the title
basil
changed the title
basil
changed the title
| <!-- TODO JENKINS-73339 until in parent POM --> | ||
| <jenkins-test-harness.version>2250.v03a_1295b_0a_30</jenkins-test-harness.version> | ||
| <maven.compiler.testRelease>17</maven.compiler.testRelease> |
There was a problem hiding this comment.
Temporary change to run tests with Jetty 12 (which requires Java 17). Note that PCT (Plugin Compatibility Tester) automatically applies these changes when this plugin is tested in jenkinsci/bom against a Jenkins core that contains Jetty 12 (e.g., the 2.472 pre-release, or the 2.472 weekly release that is scheduled for next Tuesday, August 13).
| import org.eclipse.jetty.ee8.servlet.DefaultServlet; | ||
| import org.eclipse.jetty.ee8.servlet.ServletContextHandler; | ||
| import org.eclipse.jetty.ee8.servlet.ServletHolder; |
There was a problem hiding this comment.
Jetty 11 and older were tied to a particular Servlet API version, but Jetty 12 and newer features a modular architecture that allow Jetty to be used with any Servlet API version. For EE 8, the classes have now been moved to these packages.
This is needed for this plugin's test suite to work against Jetty 12 EE 8, which PCT will start running after the 2.472 weekly release on Tuesday, August 13.
|
The CI build is green. @KostyaSha Can this PR please be merged and released before (or shortly after) the Jenkins 2.472 weekly release, currently scheduled for Tuesday, August 13? |
|
Thank you very much! |
|
you are welcome |
See JENKINS-73133. Starting on Tuesday, August 13, the 2.472 weekly release will contain Jetty 12 EE 8. For this plugin to continue to be testable in PCT (Plugin Compatibility Tester) with the upcoming 2.472 weekly release, we must adapt its test suite to work on Jetty 12 EE 8, including merging and releasing this PR.