Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Store redirect URL in a session variable #58

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Mar 13, 2022

Fixes https://issues.jenkins.io/browse/SECURITY-1833 from security advisory

Based on GitHub Oauth's solution https://github.com/jenkinsci/github-oauth-plugin/blob/master/src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java and @Wadeck 's suggestion in #17 (comment)

CC @jtnord @daniel-beck

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • [?] Ensure you have provided tests - that demonstrates feature works or fixes the issue

I didn't add any tests because I couldn't find any tests in thi repo. Setting them up is non-trivial because a mock implementation of GitLab is needed.

@zbynek
Copy link
Contributor Author

zbynek commented Mar 22, 2022

@daniel-beck @Wadeck @jtnord weekly ping 🥺

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change seems reasonable and to fix the issue on a quick glance.

@basil basil merged commit 074f3f4 into jenkinsci:master Mar 25, 2022
@zbynek zbynek deleted the store-redirect branch March 25, 2022 21:45
@basil
Copy link
Member

basil commented Mar 25, 2022

Released in 1.14.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants