Add support for customProjectName property to override default project name #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…override build.getParent().getName() * Add support for specifying project name * Fixed compile issue * Fix unit test * Fix test * Debug tests * Add unit tests
|
@asimell would you be able to review this please? |
|
@timja-kainos Yes, I was actually finally able to review this a couple of hours ago and the code looked good, but unfortunately merging it will go to next week due to personal scheduling issues. |
|
@jrjohnson87 Currently, there is no method to add a custom project name for non-pipeline jobs. Could you add the proper configuration for the config.jelly file? |
|
@asimell Updated to add this. Let me know if the help wording is acceptable or needs re-phrasing. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use case, the default project name value is making it difficult to distinguish various projects across different teams, especially PR builds. This allows a property to be specified that sets the project name value to something other than build.getParent().getName()