Cleanup Jelly files & improve wording #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Password was not very usefull as anyway anonymized.
Make sure `targets` is a `CopyOnWriteArrayList` even after data-binding. Provide drop-down via `f:select` element and `doFill<field>` method instead of doing this manually in Jelly. Use less attributes in Jelly files, relying on the fact that attributes like `name`, `value`, `checked` are derived from the `field` attribute. Use proper human readable titles for all entries. Add more help files to provide a help for every entry. Make wording and layout in existing help files more consistent.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details can be found each commit's comment.