Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[JENKINS-75003] Zip-based tool installer configuration incorrectly rejects non-HTTP(S) URLs (regression in 2.379) #10065

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

basil
Copy link
Member

@basil basil commented Dec 16, 2024

See JENKINS-75003. Amends #7398 to restore form validation support for non-HTTP(S) URLs.

Testing done

As described in the bug report, created a Maven tool with the "Extract *.zip/*.tar.gz" installer, using a download URL of file:///path/to/apache-maven-3.9.9-bin.tar.gz and a subdirectory of apache-maven-3.9.9. Verified that form validation failed before this PR and passed after this PR. Verified that a Pipeline job succeeded using this tool. Verified that a download URL of fil://path/to/invalid (invalid scheme) still reported a form validation error.

Proposed changelog entries

Allow non-HTTP(S) URLs in zip-based tool installer configuration (regression in 2.379).

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@basil basil added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Dec 16, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 16, 2024
@timja timja merged commit 34aba67 into jenkinsci:master Dec 17, 2024
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants