Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve Command Palette on mobile #10071

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 17, 2024

Some issues with Command Palette (and other inputs) on mobile (especially iOS...)

  • If an inputs font size is smaller than 16px the browser zooms in automatically
  • Accidentally had vw instead of vh for a max-height and that caused the dialog to be cut off on portrait devices
  • Width issues (didn't take up the full width of the phone)
  • Command Palette could look a little odd due to how vh is handled, changing to dvh fixes this

Before

Large image

After

Large image

Testing done

  • Tried in a simulator
  • Desktop works as before

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog accessibility Improve accessibility per WCAG guidelines labels Dec 17, 2024
@timja timja requested a review from a team December 17, 2024 22:42
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally
/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 18, 2024
@timja timja merged commit 9afbe05 into jenkinsci:master Dec 19, 2024
15 checks passed
@timja timja deleted the mobile-improvements branch December 19, 2024 09:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accessibility Improve accessibility per WCAG guidelines ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants