Form checker enhancements for radio #10081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Dec 19, 2024
| @@ -536,21 +536,24 @@ function findNext(src, filter) { | |||
| } | |||
|
|
|||
| function findFormItem(src, name, directionF) { | |||
| var name2 = "_." + name; // handles <textbox field="..." /> notation silently | |||
| const name2 = "_." + name; // handles <textbox field="..." /> notation silently | |||
There was a problem hiding this comment.
some minor tidyup in this function to use === and const / let as well
timja
commented
Dec 19, 2024
| //radio buttons have must be unique in repeatable blocks so name is prefixed | ||
| r = e.name.indexOf("_", r + 8) + 1; | ||
| if (e.tagName === "INPUT" && e.type === "radio" ) { | ||
| if (e.checked === true) { |
There was a problem hiding this comment.
moved checked out of if so it doesn't fallthrough to the return on 552
timja
commented
Dec 19, 2024
| } | ||
| return name == e.name.substring(r); | ||
| return false |
There was a problem hiding this comment.
if not checked continue and see if we can find a checked one
timja
commented
Dec 19, 2024
| if (c.tagName === 'INPUT' && c.type === "radio") { | ||
| document.querySelectorAll(`input[name='${c.name}'][type='radio']`) | ||
| .forEach(element => { | ||
| element.addEventListener("change", checker.bind(e)); |
There was a problem hiding this comment.
bind to all of the radio buttons so that when someone clicks on one form validation is updated
timja
added
the
web-ui
6 tasks
krisstern
approved these changes
Dec 20, 2024
NotMyFault
approved these changes
Dec 20, 2024
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
comment-ops-bot
bot
added
the
ready-for-merge
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same as #8832 except for general form validation and not
f:validateButtonPreviously it only found the last radio button, it tried to find the checked one but then just fell through to the general code 😢. Updates didn't work either it just bound to the returned elements and not all of the radio buttons
Testing done
Tested in Azure VM agents as part of: jenkinsci/azure-vm-agents-plugin#604
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist