Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[JENKINS-75086] Allow users with Jenkins.MANAGE to configure global build discarders #10113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mikecirioli
Copy link
Contributor

@mikecirioli mikecirioli commented Jan 3, 2025

See JENKINS-75086.

Testing done

manually verified that a user with Jenkins.MANAGE can configure the global buiild discarders

Proposed changelog entries

  • Users with Overall/Manage permission can now configure global build discarders.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@mikecirioli mikecirioli marked this pull request as ready for review January 3, 2025 12:49
@mikecirioli mikecirioli closed this Jan 3, 2025
@mikecirioli mikecirioli reopened this Jan 3, 2025
@mikecirioli mikecirioli reopened this Jan 3, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikecirioli LGTM.

@daniel-beck daniel-beck added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Jan 7, 2025
@jtnord jtnord requested a review from daniel-beck January 9, 2025 12:59
@jtnord jtnord added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 9, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants