Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Cancel button to the Edit description form #10364

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mawinter69
Copy link
Contributor

When one clicks on Add or Edit description, it is not possible to cancel this. The only action to revert from here is to reload the page. This is bad UX.

This adds a Cancel button to overcome this.

The buttons are now aligned to the left.

Before:
image

After:
image

See JENKINS-XXXXX.

Testing done

  • create freestyle and job with description and saved it, clicked on "Edit description" (it is in the app-bar), changed text, then pressed "Cancel" -> original text is shown, clicked again on "Edit description" -> form is loaded properly
  • Done the same for a matrix job (the button is next to the form)
  • And checked this for the view description

Proposed changelog entries

  • Add Cancel button to the Edit description form

Proposed changelog category

/label rfe,web-ui

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

When one clicks on Add or Edit description, it is not possible to cancel
this. The only action to revert from here is to reload the page. This is
bad UX.

This adds a Cancel button to overcome this.
@comment-ops-bot comment-ops-bot bot added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Mar 2, 2025
@mawinter69 mawinter69 marked this pull request as draft March 2, 2025 21:36
@mawinter69 mawinter69 marked this pull request as ready for review March 3, 2025 07:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant