Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove icomoon #7958

Merged
merged 3 commits into from
May 9, 2023
Merged

Remove icomoon #7958

merged 3 commits into from
May 9, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented May 7, 2023

Icomoon is only used in the setup wizard, where it's used for three icons - the watermark behind the page, and the invisible? icons on the Customise Jenkins buttons.

image

I've removed the elements that show these icons as I don't think they're contributing anything design wise to the page (if anything dating it) and the icons on the buttons aren't visible for some reason any way. As part of the transition to SCSS it'd be good to remove this dependency to make it easier/cleaner to switch.

Testing done

Setup wizard works as before (albeit without the watermark behind the page)

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@timja timja added the skip-changelog Should not be shown in the changelog label May 7, 2023
@basil basil self-assigned this May 7, 2023
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 7, 2023
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label May 8, 2023
@basil basil merged commit b9fae47 into jenkinsci:master May 9, 2023
@timja timja deleted the remove-icomoon branch May 12, 2023 08:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants