Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix encoding of Brazilian Portuguese localization #8549

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

basil
Copy link
Member

@basil basil commented Oct 2, 2023

#8543 (accidentally?) changed the encoding of a Brazilian Portuguese localization from UTF-8 to ISO-8859-1. As of a few months back we have been trying to keep all properties files in UTF-8.

Testing done

$ file core/src/main/resources/jenkins/monitor/JavaVersionRecommendationAdminMonitor/description_pt_BR.properties 
core/src/main/resources/jenkins/monitor/JavaVersionRecommendationAdminMonitor/description_pt_BR.properties: Unicode text, UTF-8 text

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@basil basil added the skip-changelog Should not be shown in the changelog label Oct 2, 2023
@basil basil requested a review from MarkEWaite October 2, 2023 19:01
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my mistake! I was relying on emacs to preserve all the right things with character sets, but that was obviously not enough.

@basil basil merged commit 725f8f3 into jenkinsci:master Oct 2, 2023
@basil basil deleted the utf-8 branch October 2, 2023 19:14
flabrie pushed a commit to flabrie/jenkins that referenced this pull request Oct 2, 2023
* master:
  Bump org.jenkins-ci:jenkins from 1.105 to 1.106 (jenkinsci#8550)
  Bump asm.version from 9.5 to 9.6 (jenkinsci#8545)
  Fix encoding of Brazilian Portuguese localization (jenkinsci#8549)
  Warn users of old Java version 18 months before end of life (jenkinsci#8543)
  Bump org.jenkins-ci.plugins:credentials from 1271.v54b_1c2c6388a_ to 1290.v2e5b_13eb_b_127 (jenkinsci#8548)
  Bump com.puppycrawl.tools:checkstyle from 10.12.3 to 10.12.4 (jenkinsci#8547)
  Bump io.jenkins.plugins:plugin-util-api from 3.3.0 to 3.4.0 (jenkinsci#8538)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants