[FIXED JENKINS-19752] write in the correct outputstream #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
core » jenkins_main_trunk #1231 UNSTABLE |
|
it looks like this test is randomly failing... The pull request is not related to the User management or anything like that... And the coverage report of this test shows us that the modified class DirectoryBrowserSupport is not used... I fixed the unit test to wait until the job is complete, otherwise it is filtered and user does not belong to the build. It was clearly depending on the server load. |
|
core » jenkins_main_trunk #1233 UNSTABLE |
olivergondza
added a commit
that referenced
this pull request
Sep 26, 2013
|
Merged commit 11fe787 fixing JENKINS-19752. The test failure was, as you said, unrelated to your changes. I will create a proper fix later. Thanks for contributing. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the isse that appears in 1.532 and that corrupts all the zip generated by DirectoryBrowserSupport (https://issues.jenkins-ci.org/browse/JENKINS-19752)
http://job/zenika/lastSuccessfulBuild/artifact/repository/output/_zip_/output.zip
The process was not writing in the correct output stream.
This issue is quite annoying as you cannot download anymore the artifacts in a single file (zip)