Fix dropdowns being added multiple times to the same element #9835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat subtle bug, discovered in https://github.com/jenkinsci/acceptance-test-harness/pull/1756/checks?check_run_id=31138933435. Essentially if
applySubtree
is called on an overflow button, it triggers another dropdown to be added to it. They overlap so it's still functional, however it is visible by the dropdown having a very dark shadow as a result.This PR fixes that by destroying any existing dropdowns before adding another one, the same way the tooltips operate in https://github.com/jenkinsci/jenkins/blob/master/war/src/main/js/components/tooltips/index.js#17.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist