Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolved managed Maven plugin dependency versioning #417

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Resolved managed Maven plugin dependency versioning #417

merged 1 commit into from
Nov 5, 2020

Conversation

ohbus
Copy link
Contributor

@ohbus ohbus commented Nov 5, 2020

Removed explicit versioning to help eliminate conflicts for three parent managed dependencies

  • org.apache.maven.plugins.maven-assembly-plugin

  • org.apache.maven.plugins.maven-resources-plugin

  • org.jvnet.maven-antrun-extended-plugin.maven-antrun-extended-plugin

@ohbus ohbus requested a review from a team as a code owner November 5, 2020 08:22
@oleg-nenashev oleg-nenashev added the dependencies Pull requests that update a dependency file label Nov 5, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not recall what exactly led to having these dependencies pinned explicitly. Likely it was a copy-paste at some point. Parent POM now includes recent versions for all Maven plugins it declares, so it should not be a problem to drop explicit version definitions

@oleg-nenashev oleg-nenashev merged commit 62809b1 into jenkinsci:master Nov 5, 2020
@oleg-nenashev oleg-nenashev changed the title Resolved managed dependencies versioning Resolved managed Maven plugin dependency versioning Nov 5, 2020
@oleg-nenashev
Copy link
Member

Thanks for the patch!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants