Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[JENKINS-25829] Use proxy settings for REST API calls #386

Merged
merged 4 commits into from
Nov 5, 2021
Merged

[JENKINS-25829] Use proxy settings for REST API calls #386

merged 4 commits into from
Nov 5, 2021

Conversation

outbreaker
Copy link
Contributor

Use Jenkins Proxy-Settings for getVersions and other calls at JiraRestService

fix #385

@rantoniuk rantoniuk changed the title Bugfix/issue 385 Use proxy settings for REST API calls Oct 27, 2021
@rantoniuk
Copy link
Contributor

Hi @outbreaker, thanks a lot for picking up this long open bug.
Could you add a simple unit test for this change?

@rantoniuk rantoniuk changed the title Use proxy settings for REST API calls [JENKINS-25829] Use proxy settings for REST API calls Oct 27, 2021
@outbreaker
Copy link
Contributor Author

Yes, i create Tests asap

@olamy olamy added the feature Release Drafter label label Nov 1, 2021
@outbreaker
Copy link
Contributor Author

Hi @rantoniuk.
tests for proxy and non proxy usage added.

@rantoniuk rantoniuk merged commit 092fe42 into jenkinsci:master Nov 5, 2021
@rantoniuk
Copy link
Contributor

Thanks a lot for the contribution!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Release Drafter label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy not used for getVersions
3 participants
@outbreaker @rantoniuk @olamy